std::string_view support in Rcpp::wrap()#1356
Merged
eddelbuettel merged 4 commits intoRcppCore:masterfrom Feb 4, 2025
Merged
Conversation
Member
|
Would you mind filling in the template you carried over unchanged? |
Contributor
Author
|
This is a draft I created solely to reference in an issue I'm about to open to start a discussion :) |
Member
|
Looking forward to it -- ex ante it's a good topic and something that would be nice to fill in. |
Member
|
(Updated your first box above: if you make it This looks good. I will toss this at the reverse dependency checker which, being underpowered on an ancient old box, will take a while. We will know more in a few days. |
Member
|
There were no regressions, or, in the parlance, "changes to worse" so no objections from the reverse-depends check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
Rcpp::wrap()treats astd::string_viewargument by default as a generic container and creates a character vector from single characters. This is different from howstd::stringis handled. This change aligns the two, so thatwrap("foo"sv)is equivalent towrap("foo"s). The added code is conditionally compiled for C++17.Checklist
R CMD checkstill passes all tests